-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scipy to optional requirements #1233
Conversation
* Move scipy to optional requirements * Update changelog * Add test for missing scipy importerror * Fix test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1233 +/- ##
=======================================
Coverage 90.87% 90.88%
=======================================
Files 42 42
Lines 9524 9532 +8
Branches 1921 1922 +1
=======================================
+ Hits 8655 8663 +8
Misses 576 576
Partials 293 293 ☔ View full report in Codecov by Sentry. |
@rly Before I approve, could you add tests or coverage skips for the missing lines. |
Thanks. Good catch. After merging the changes in |
See #1140
Checklist
CHANGELOG.md
with your changes?