Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scipy to optional requirements #1233

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Move scipy to optional requirements #1233

merged 7 commits into from
Jan 22, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 17, 2025

See #1140

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

rly added 3 commits July 7, 2024 21:01
* Move scipy to optional requirements

* Update changelog

* Add test for missing scipy importerror

* Fix test
@rly rly requested a review from mavaylon1 January 17, 2025 18:17
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (ff4a0aa) to head (2f17516).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1233   +/-   ##
=======================================
  Coverage   90.87%   90.88%           
=======================================
  Files          42       42           
  Lines        9524     9532    +8     
  Branches     1921     1922    +1     
=======================================
+ Hits         8655     8663    +8     
  Misses        576      576           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/unit/common/test_sparse.py Outdated Show resolved Hide resolved
@mavaylon1
Copy link
Contributor

@rly Before I approve, could you add tests or coverage skips for the missing lines.

@rly
Copy link
Contributor Author

rly commented Jan 21, 2025

@rly Before I approve, could you add tests or coverage skips for the missing lines.

Thanks. Good catch. After merging the changes in pyproject.toml, scipy crept back in as a primary dependency, and so no coverage tests were run without scipy installed.

@rly rly enabled auto-merge (squash) January 21, 2025 21:53
@rly rly merged commit 775fa3b into dev Jan 22, 2025
27 checks passed
@rly rly deleted the hdmf_4.0 branch January 22, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants