Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Add stories for chart componenets #2821

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Jan 31, 2025

References #931

Brief overview:

  • Charts.tsx originally had 4 chart components, from which CpuCircularChart and MemoryCirclularChart components had similar props, while PodStatusCircularChart and NodeStatusCircularChart had similar props.
  • So, refactored chart.tsx into ResourceCharts and StatusCharts
  • Created .Stories.tsx for both.
  • Created index file and updated imports (if any).

@illume PR is currently ready for review, needed your opinion weather we should have done this separation of files or not?
IMO it was too messy to deal this in single story file so refatrored a bit. Thanks !

Here's storybook video of current state:
Screencast from 2025-01-31 23-57-28.webm

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 31, 2025
@Faakhir30 Faakhir30 force-pushed the feat/new-chart-stories branch from 7de09b1 to f2c2b61 Compare January 31, 2025 22:20
@Faakhir30 Faakhir30 force-pushed the feat/new-chart-stories branch from f2c2b61 to dd236ce Compare February 4, 2025 01:09
@Faakhir30 Faakhir30 requested a review from sniok February 4, 2025 01:11
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@sniok sniok merged commit f0b3e18 into headlamp-k8s:main Feb 7, 2025
15 checks passed
@Faakhir30 Faakhir30 deleted the feat/new-chart-stories branch February 7, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants