Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update platformname and automationname #42

Merged
merged 1 commit into from
Mar 1, 2024
Merged

docs: update platformname and automationname #42

merged 1 commit into from
Mar 1, 2024

Conversation

KazuCocoa
Copy link
Contributor

@KazuCocoa KazuCocoa commented Mar 1, 2024 •
edited
Loading

"platformName"
Lowercase name of the current platform as a string.

https://www.w3.org/TR/webdriver1/

So, the capabilities are also nice to address lowercase. automationName is also. (Appium's internal handles as lower case, so it should not be matter)

@KazuCocoa KazuCocoa requested a review from jlipps March 1, 2024 09:44
jlipps
jlipps approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a docs only change right? I think we probably do a case insensitive check in the code?

@KazuCocoa
Copy link
Contributor Author

Yes, appium server has been handled them as lowercase internally, so this is just docs correction

@KazuCocoa KazuCocoa merged commit d365299 into main Mar 1, 2024
10 checks passed
@KazuCocoa KazuCocoa deleted the KazuCocoa-patch-1 branch March 1, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KazuCocoa @jlipps