-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chromedriverExecutableDir and autodownload support #48
Conversation
Co-authored-by: Jonathan Lipps <[email protected]>
@jlipps maybe we could create 0.3.0 with this. |
it's now published. |
@KazuCocoa @jlipps autodownload not work on my side appium server --allow-insecure chromedriver_autodownload |
Because the embedded browser did not respond what chrome version the device needed. This implementation cares https://github.com/headspinio/appium-lg-webos-driver/pull/48/files#diff-9dd24cf3101d02ce31204899de7beaa39759860d491e54541dcc55c10ec2ae32R37-R117 cases, but not sure what chromedriver should be used for your device case.
|
#50 to return better error message as no info to guess necessary chromedriver version |
Closes #43
cc @jlipps