Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chromedriverExecutableDir and autodownload support #48

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

KazuCocoa
Copy link
Contributor

@KazuCocoa KazuCocoa commented Mar 11, 2024

Closes #43
cc @jlipps

@KazuCocoa KazuCocoa marked this pull request as ready for review March 11, 2024 20:14
@KazuCocoa KazuCocoa requested a review from jlipps March 11, 2024 20:14
Co-authored-by: Jonathan Lipps <[email protected]>
@KazuCocoa KazuCocoa merged commit 73a8656 into main Mar 11, 2024
10 checks passed
@KazuCocoa KazuCocoa deleted the chrome-autodownload branch March 11, 2024 21:45
@KazuCocoa
Copy link
Contributor Author

@jlipps maybe we could create 0.3.0 with this.

@jlipps
Copy link
Collaborator

jlipps commented Mar 11, 2024

it's now published.

@Jiyvn
Copy link

Jiyvn commented Mar 21, 2024

@KazuCocoa @jlipps autodownload not work on my side
image
image

appium server --allow-insecure chromedriver_autodownload
lgtv2019.log

@KazuCocoa
Copy link
Contributor Author

KazuCocoa commented Mar 21, 2024

Because the embedded browser did not respond what chrome version the device needed. This implementation cares https://github.com/headspinio/appium-lg-webos-driver/pull/48/files#diff-9dd24cf3101d02ce31204899de7beaa39759860d491e54541dcc55c10ec2ae32R37-R117 cases, but not sure what chromedriver should be used for your device case.

WebKit-Version":"537.36 is very common value as the device so it does not help to guess necessary chromedriver. What we could do here is return better error message for this "User-Agent":"" case.

�[38;5;48m[WebOSDriver]�[0m Waiting for app launch to take effect
�[38;5;48m[WebOSDriver]�[0m Waiting for app launch to take effect
�[38;5;48m[WebOSDriver]�[0m The response of http://192.168.10.187:9998/json/version was {"Browser":"","Protocol-Version":"1.1","User-Agent":"","WebKit-Version":"537.36 (@fa89da905405aab455e0f0d4ec7f49631c7ca70b)"}
�[38;5;80m[Chromedriver@b2fd]�[0m Changed state to 'starting'
�[38;5;80m[Chromedriver@b2fd]�[0m Using the static Chromedriver->Chrome mapping
�[38;5;80m[Chromedriver@b2fd]�[0m The most recent known Chrome version: 123.0.6312
�[38;5;80m[Chromedriver@b2fd]�[0m Found 0 executables in '/Users/jiyvn/aviu/apps/lgtv/chromedriver/'

@KazuCocoa
Copy link
Contributor Author

#50 to return better error message as no info to guess necessary chromedriver version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable autodownlaod capability
3 participants