chore(): ungulpify #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds types, prettier, lint-staged, CI, usual suspects - changes `xmldom` dep to `@xmldom/xmldom`
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
just reopening #4 so I can stack PRs on it |
KazuCocoa
approved these changes
Oct 21, 2022
|
fwiw I'm not eager to merge this until I can run some E2E tests, which I hope to get setup today |
jlipps
approved these changes
Oct 24, 2022
| @@ -0,0 +1,13 @@ | |||
| # editorconfig.org | |||
| @@ -0,0 +1 @@ | |||
| *.tsbuildinfo | |||
There was a problem hiding this comment.
question: i forget how .npmignore works. is it additive to what's in .gitignore?
There was a problem hiding this comment.
npm does not consider .gitignore when publishing files (otherwise build artifacts would not get published); it only considers the files prop (which is an allow-list) and the .npmignore file (which is a deny-list).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds types, prettier, lint-staged, CI, usual suspects
typechecking is disabled; fixes for types should be in another PR (likewise formatting)