Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerizes start script #559

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Dockerizes start script #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3dfb654
adds initial dockerfiles
DylanTackoor Jan 24, 2022
7934aa5
adds node version range for npm install warnings
DylanTackoor Jan 24, 2022
958c9bd
node engines version fixes
DylanTackoor Jan 24, 2022
c535cb7
dockerfile fix that still doesn't let me load the webpack server
DylanTackoor Jan 25, 2022
89c35b4
adds --host 0.0.0.0 to start script
DylanTackoor Jan 27, 2022
e0fcbed
final docker fixes
DylanTackoor Jan 27, 2022
9f86bd6
Naming update + removed unnecessary file
DylanTackoor Jan 27, 2022
7f36a66
Actually removes old Dockerfile
DylanTackoor Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
FROM node:12.16.1

WORKDIR /app

COPY package.json .
COPY package-lock.json .
COPY dist/ ./dist
COPY example/ ./example
COPY scripts/ ./scripts
COPY scss/ ./scss
COPY src/ ./src
COPY test/ .
COPY .babelrc .
COPY .eslintrc.js .
COPY index.js .
COPY mapdc.css .
COPY webpack.config.js .
COPY sonar-project.properties .

RUN npm ci

EXPOSE 8080

CMD ["npm", "start"]
15 changes: 15 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
version: '3'

services:
charting:
container_name: charting
build:
context: .
dockerfile: Dockerfile.dev
ports:
- 8080:8080
volumes:
- ./src:/app/src
- ./example:/app/example
- ./scripts:/app/scripts
- ./dist:/app/dist
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"license": "Apache-2.0",
"copyright": "2017",
"description": "A multi-dimensional charting library built to work natively with crossfilter and rendered using d3.js.",
"engines": {
"node": ">=6.13.4 <=12.16.1"
},
"keywords": [
"visualization",
"svg",
Expand Down Expand Up @@ -48,7 +51,7 @@
"report": "nyc report --reporter=lcov && open coverage/lcov-report/index.html",
"selenium:install": "selenium-standalone install --version=3.0.0-beta4",
"selenium:start": "selenium-standalone start --version=3.0.0-beta4",
"start": "webpack-dev-server --content-base ./example --config ./example/webpack.config.js",
"start": "webpack-dev-server --host 0.0.0.0 --content-base ./example --config ./example/webpack.config.js",
"test": "npm run format:check:silent && npm run lint && npm run test:unit",
"test:unit": "find ./src -name '*.spec.js' | BABEL_ENV=test NODE_PATH=./src xargs nyc mocha --opts ./test/mocha.unit.opts"
},
Expand Down