Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added valueClass to schema #246

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Added valueClass to schema #246

merged 3 commits into from
Jul 2, 2021

Conversation

VisLab
Copy link
Member

@VisLab VisLab commented Jul 2, 2021

The beta.3 version of the schema and XSD have the following updates:

  1. The textClass, nameClass, numericClass, posixPath, and dateTime are now part of a new valueClass not unitClass.
  2. The isNumeric schema attribute has been removed.
  3. A valueProperty has been added to the schema attribute properties.

This PR partially addresses the following issues:

Note: I hand edited both the MEDIAWIKI and the XML so there might be errors. The XML validates with the XSD but was produced manually, rather than by the hedtools.

I think we should go ahead with this modification unless serious issues are raised. It gives us a path forward to address the issues listed above in a consistent way. If we adopt, the tools need to be able to read schema in the new form, but taking advantage for validation does not need to be included in this release. It can be addressed in the future.

Please comment @IanCa @happy5214 @dungscout96 @sappelhoff

@VisLab VisLab merged commit 7517ac7 into hed-standard:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant