-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/on all fields filled #42
base: master
Are you sure you want to change the base?
Conversation
@@ -175,7 +182,7 @@ export default class Form extends InputContainer { | |||
}); | |||
} | |||
|
|||
_validateOne(iptName, context) { | |||
_validateOne(iptName, context, setError=true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the argument in the function has proper spacing,
setError = true
vs setError =true
|
||
if (typeof this.props.validateAllCallback === 'function') { | ||
let values = this.getValues(); | ||
let { isValid, errors } = this._validateAll(values, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errors
is unused here
|
||
return isValid; | ||
} | ||
|
||
_validateAll(context) { | ||
_validateAll(context, setError=true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing about spaces between assignment
No description provided.