fix: allow default_integrations to actually turn off the defaults
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* in addition, we provide the defaults as a sub in case the user wants
to manually add them (delaying initialization could make a difference)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to manually add them (delaying initialization could make a difference)
If there's anything you'd want changed in the implementation, i'm happy to do so. I
personally need this b/c I used to get memory leaks from spans very early in my mojo app,
so i had to patch the code locally to turn off storing any breadcrumbs outside of the
req/res cycle.
In any case, the docs claim that you can turn off the default integrations, and before
this patch that is not the case.
I also changed the default value for
default_integrationsto 1 rather than empty arrayb/c it's not meant to be an array