Skip to content

Commit

Permalink
Fix ingestion pipeline to identify scope (microsoft#1025)
Browse files Browse the repository at this point in the history
  • Loading branch information
flanakin authored Oct 2, 2024
1 parent 1e6be3d commit 695e12f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 9 deletions.
4 changes: 4 additions & 0 deletions docs/_reporting/power-bi/rate-optimization.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ There are 2 charts on the page that offer a breakdown of location, instance size
The table below the charts shows the recommended reservations based on the specified lookback period.

<blockquote class="important" markdown="1">
_The reservation recommendations page utilizes Cost Management exports either directly in storage (via the **Export Storage URL** parameter) or as part of FinOps hubs. If you do not see recommendations, confirm that you have configured exports and the filters at the top of the page align to the recommendations you exported (e.g., term, lookback, scope)._
</blockquote>

<blockquote class="note" markdown="1">
_Potential savings and contracted cost estimations are only available for VM reservation recommendations. This page has not been tested for non-VM recommendations. You can view savings plan and reservation recommendations for other services in the Azure portal._
</blockquote>

Expand Down
8 changes: 4 additions & 4 deletions docs/deploy/finops-hub-0.6.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "6086027768135226924"
"templateHash": "2663349633229182576"
}
},
"parameters": {
Expand Down Expand Up @@ -132,7 +132,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "8283603935740018840"
"templateHash": "6613119753589229935"
}
},
"parameters": {
Expand Down Expand Up @@ -639,7 +639,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "4613582767835961191"
"templateHash": "1110313222495299332"
}
},
"functions": [
Expand Down Expand Up @@ -2653,7 +2653,7 @@
"userProperties": [],
"typeProperties": {
"on": {
"value": "@if(empty(variables('mcaColumnToCheck')), 'ignore', last(array(activity('Read Manifest').output.firstRow.blobs[0].blobName)))",
"value": "@if(empty(variables('mcaColumnToCheck')), 'ignore', last(array(split(activity('Read Manifest').output.firstRow.blobs[0].blobName, '.'))))",
"type": "Expression"
},
"cases": [
Expand Down
8 changes: 4 additions & 4 deletions docs/deploy/finops-hub-latest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "6086027768135226924"
"templateHash": "2663349633229182576"
}
},
"parameters": {
Expand Down Expand Up @@ -132,7 +132,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "8283603935740018840"
"templateHash": "6613119753589229935"
}
},
"parameters": {
Expand Down Expand Up @@ -639,7 +639,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "4613582767835961191"
"templateHash": "1110313222495299332"
}
},
"functions": [
Expand Down Expand Up @@ -2653,7 +2653,7 @@
"userProperties": [],
"typeProperties": {
"on": {
"value": "@if(empty(variables('mcaColumnToCheck')), 'ignore', last(array(activity('Read Manifest').output.firstRow.blobs[0].blobName)))",
"value": "@if(empty(variables('mcaColumnToCheck')), 'ignore', last(array(split(activity('Read Manifest').output.firstRow.blobs[0].blobName, '.'))))",
"type": "Expression"
},
"cases": [
Expand Down
2 changes: 1 addition & 1 deletion src/templates/finops-hub/modules/dataFactory.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -1946,7 +1946,7 @@ resource pipeline_ExecuteETL 'Microsoft.DataFactory/factories/pipelines@2018-06-
userProperties: []
typeProperties: {
on: {
value: '@if(empty(variables(\'mcaColumnToCheck\')), \'ignore\', last(array(activity(\'Read Manifest\').output.firstRow.blobs[0].blobName)))'
value: '@if(empty(variables(\'mcaColumnToCheck\')), \'ignore\', last(array(split(activity(\'Read Manifest\').output.firstRow.blobs[0].blobName, \'.\'))))'
type: 'Expression'
}
cases: [
Expand Down

0 comments on commit 695e12f

Please sign in to comment.