Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Michael Flanakin <[email protected]>
  • Loading branch information
helderpinto and flanakin authored Apr 11, 2024
1 parent db6fb0a commit a3e9129
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/optimization-engine/setup-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Advanced scenarios for setting up or upgrading AOE.

</details>

---

## 🎛️ Using a local repository

If you choose to deploy all the dependencies from your own local repository, you must publish the solution files into a publicly reachable URL. You must ensure the entire AOE project structure is available at the same base URL. Storage Account SAS Token-based URLs are not supported.
Expand Down
2 changes: 2 additions & 0 deletions docs/optimization-engine/suppressing-recommendations.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Adjust the recommendations results to your environment characteristics.

</details>

---

When working on the recommendations provided by AOE, you may find some cases where the recommendation does not apply for some reason. For example, AOE is suggesting high availability recommendations that do not apply to Dev/Test Virtual Machines, or recommending enabling Azure Backup for non-critical VMs. You can suppress recommendations in two ways:

* If recommendations are originated from Azure Advisor, you can simply go to the Azure Portal and [dismiss/postpone the recommendation](https://docs.microsoft.com/en-us/azure/advisor/view-recommendations#dismissing-and-postponing-recommendations).
Expand Down
2 changes: 2 additions & 0 deletions src/optimization-engine/Deploy-AzureOptimizationEngine.ps1
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# TODO: Add doc comments
param (
[Parameter(Mandatory = $false)]
[string] $TemplateUri,
Expand Down Expand Up @@ -472,6 +473,7 @@ if ($null -eq $sql -and -not($sqlServerName -like "*.database.*") -and -not($Ign

$SqlServerNameAvailabilityUriPath = "/subscriptions/$subscriptionId/providers/Microsoft.Sql/checkNameAvailability?api-version=2014-04-01"
$body = "{`"name`": `"$sqlServerName`", `"type`": `"Microsoft.Sql/servers`"}"
# TODO: Switch to custom Invoke-Rest command to leverage telemetry tracking
$sqlNameResult = (Invoke-AzRestMethod -Path $SqlServerNameAvailabilityUriPath -Method POST -Payload $body).Content | ConvertFrom-Json

if (-not($sqlNameResult.available)) {
Expand Down

0 comments on commit a3e9129

Please sign in to comment.