Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISO value handling #371

Closed
wants to merge 61 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
563f885
change setup.py to production
helgeerbe Mar 10, 2021
6236fa4
Merge branch 'ctrl-c' into main
helgeerbe Mar 20, 2021
de3710a
Merge branch 'dev' into main
helgeerbe Apr 2, 2021
19eb162
Merge remote-tracking branch 'origin/dev' into main
helgeerbe May 2, 2021
fc652ee
Initial fix for issue #110 (image_cache bug)
jgodfrey May 2, 2021
882082a
Merge pull request #111 from helgeerbe/Issue-110
jgodfrey May 2, 2021
0b08dfb
Revert "Merge pull request #111 from helgeerbe/Issue-110"
helgeerbe May 3, 2021
39652b7
Merge remote-tracking branch 'origin/dev' into main
helgeerbe May 5, 2021
5880c39
Merge pull request #113 from helgeerbe/dev
helgeerbe May 5, 2021
62db18f
Update README.md
helgeerbe Jun 6, 2021
9be6d56
Update README.md
helgeerbe Jun 6, 2021
d76ab05
Update README.md
helgeerbe Jun 6, 2021
9c1222c
Merge remote-tracking branch 'origin/dev' into main
helgeerbe Jun 26, 2021
b0fddbb
Merge remote-tracking branch 'origin/dev' into main
helgeerbe Jul 5, 2021
07bbaaf
Update README.md
jgodfrey Aug 26, 2021
64e1fa9
Merge remote-tracking branch 'origin/dev'
helgeerbe Aug 30, 2021
e68baaa
Merge remote-tracking branch 'origin/dev'
helgeerbe Sep 22, 2021
6fb1b25
Merge remote-tracking branch 'origin/dev' into main
helgeerbe Oct 6, 2021
ecc74eb
Merge branch 'main' of https://github.com/helgeerbe/picframe into main
helgeerbe Oct 6, 2021
5574fde
Merge remote-tracking branch 'origin/dev'
helgeerbe Nov 4, 2021
e6e8b04
Merge remote-tracking branch 'origin/dev'
helgeerbe Jan 20, 2022
941aa8f
Update Readme
helgeerbe Jan 20, 2022
20dd378
Merge remote-tracking branch 'origin/dev'
helgeerbe Jan 21, 2022
13da664
Update issue templates
helgeerbe Jan 26, 2022
62139df
Merge remote-tracking branch 'origin/dev'
helgeerbe Mar 24, 2022
c6479e2
Merge remote-tracking branch 'origin/dev'
helgeerbe Apr 19, 2022
111158a
Merge remote-tracking branch 'origin/dev'
helgeerbe Jun 3, 2022
9707f40
Update python-publish.yml
helgeerbe Nov 24, 2022
3930e4e
Merge branch 'dev'
helgeerbe Dec 4, 2022
9507360
Merge remote-tracking branch 'origin/dev'
helgeerbe Dec 13, 2022
f6550cc
Create python-package-conda.yml
helgeerbe Dec 13, 2022
e1591dd
Create python-publish_token.yml
helgeerbe Dec 13, 2022
c86eafe
Update python-publish.yml
helgeerbe Dec 13, 2022
ec7f24d
Update python-publish_token.yml
helgeerbe Dec 13, 2022
a789c11
Update python-publish_token.yml
helgeerbe Dec 13, 2022
5ea60ac
Update python-publish_token.yml
helgeerbe Dec 13, 2022
e3ad3b4
Update python-publish_token.yml
helgeerbe Dec 13, 2022
724ddc3
Merge branch 'dev'
helgeerbe Dec 15, 2022
fc087d8
add action: publish to pypi on release
helgeerbe Dec 15, 2022
9a43248
Update python-publish_token.yml
helgeerbe Dec 15, 2022
ab427f5
Update python-publish_token.yml
helgeerbe Dec 15, 2022
2829e84
Create python-package-conda.yml
helgeerbe Dec 16, 2022
2c1b877
Update python-package-conda.yml
helgeerbe Dec 16, 2022
e539448
Update python-package-conda.yml
helgeerbe Dec 16, 2022
1ce8918
Delete python-package-conda.yml
helgeerbe Dec 16, 2022
376fe1a
Create test.yml
helgeerbe Dec 16, 2022
25d3b48
Update test.yml
helgeerbe Dec 16, 2022
a02bb64
Update test.yml
helgeerbe Dec 16, 2022
c5294e2
Update test.yml
helgeerbe Dec 16, 2022
60237a4
Update test.yml
helgeerbe Dec 16, 2022
dab5ecf
Update README.md
helgeerbe Dec 22, 2022
b621dc7
Merge branch 'dev'
helgeerbe May 15, 2023
8043133
Merge branch 'dev'
helgeerbe May 15, 2023
60dfad9
Merge branch 'dev'
helgeerbe May 15, 2023
f576a80
Merge branch 'dev'
helgeerbe May 15, 2023
4415afa
Merge branch 'dev'
helgeerbe May 15, 2023
e37ff86
Merge branch 'dev'
helgeerbe May 15, 2023
a98ccbe
Merge branch 'dev'
helgeerbe May 17, 2023
3b25036
Merge branch 'dev'
helgeerbe Jun 12, 2023
67a3e3f
Merge branch 'dev'
helgeerbe Jul 26, 2023
f4f034e
Fix ISO value handling
jgodfrey Feb 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions .github/ISSUE_TEMPLATE/issue-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
---
name: Issue report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

<!--
Thank you for reporting an issue.

Follow these guidelines to ensure your issue is handled properly.

If you have a ...

1. General question: consider asking the question in the discussion section

* https://github.com/helgeerbe/picframe/discussions

Do not ask a question in both places.

If you think you have found a bug or have an unexplained exception
then file a bug report here.

2. Bug report: Provide a clear and concise description of what the bug is.

3. Feature request: do a quick search of existing issues
to make sure this has not been asked before.

We know asking good questions takes effort, and we appreciate your time.
Thank you.
-->


**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**What are your OS, Python and picframe versions(please complete the following information):?**

- Hardware:
- OS:
- Python:
- picframe (run `picframe -v` if possible):

<!--
Please include **configuration.yaml** and **log infos** that reproduces the issue and whenever possible, an **image** that demonstrates the issue. Please upload images to GitHub, not to third-party file hosting sites. If necessary, add the image to a zip or tar archive.
-->

```yaml
configuration.yaml goes here
```

````txt
log output goes here
````

**Additional context**
Add any other context about the problem here.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

![picframe logo](https://github.com/helgeerbe/picframe/wiki/images/Picframe_Logo.png)

- [![PyPI version](https://badge.fury.io/py/picframe.svg)](https://badge.fury.io/py/picframe)
- [PictureFrame powered by pi3d](#pictureframe-powered-by-pi3d)
- [What Is PictureFrame?](#what-is-pictureframe)
- [History of PictureFrame](#history-of-pictureframe)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ readme = "README.md"
license = {text = "MIT"}
requires-python = ">=3.7"
classifiers=[
"Development Status :: 4 - Beta",
"Development Status :: 5 - Production/Stable",
"License :: OSI Approved :: MIT License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
Expand Down
3 changes: 3 additions & 0 deletions src/picframe/get_image_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ def get_exif(self, key):
for iso in iso_keys:
val = self.__get_if_exist(iso)
if val:
# If ISO is returned as a tuple, take the first element
if type(val) is tuple:
val = val[0]
break
else:
val = self.__get_if_exist(key)
Expand Down
Loading