Show path in file picker and explorer #12806
Open
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file picker and explorer can each be opened in several ways, each causing it to have a different root path. What's more, the file explorer can change its path while you have it open. This can make it very difficult to keep track of the root directory for these pickers, so we add it as a header. If desired, we could alternatively make this a configuration option, but I see little downside to always including it.
|
@David-Else is this what you were talking about when you said where the path of the pickers should be? The path is directly above the items, replacing the usual picker column headers. I actually really like this idea! |
nik-rev
reviewed
Feb 8, 2025
| @@ -235,7 +235,7 @@ pub fn file_picker(root: PathBuf, config: &helix_view::editor::Config) -> FilePi | |||
| log::debug!("file_picker init {:?}", Instant::now().duration_since(now)); | |||
|
|
|||
| let columns = [PickerColumn::new( | |||
| "path", | |||
| root.to_string_lossy(), | |||
There was a problem hiding this comment.
Instead of showing the absolute path, I think it'd be cleaner to show the relative path. Using helix_stdx::path::get_relative_path
|
This PR also hides the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file picker and explorer can each be opened in several ways, each causing it to have a different root path. What's more, the file explorer can change its path while you have it open.
This can make it very difficult to keep track of the root directory for these pickers, so we add it as a header.
If desired, we could alternatively make this a configuration option, but I see little downside to always including it.
Example: