-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic completion item kind suport #9996
Conversation
Can you comeup with a set of icons that don't require a patched font as a default? Otherwise, this feature should have an enable setting that defaults to false. Helix should work out of the box without installing a patched font |
Ah nvm I see that you default to the item name. That is a good default, I like this approach much better than enabling icons by default |
Instead of using a HashMap for completion_item_kinds, use a Vec of tuples, this way we do not need a wrapper to implement hash. The second modification involves serializing, again, instead of using a wrapper for the struct, serde's deserialize_with attribute is used, this also allows us to serialize using a snake_name case instead of PascalCase
This looks great! Any chance the merge conflicts could be fixed? Also, could you add your optional nerd fonts config to the documentation, maybe to the |
Closed in favor of #12151 |
This PR allows the completion menu's style to be more configurable, allowing configurations like this:
The concerned configuration options are:
editor.completion-item-columns
: A list of eithername
orkind
, for the symbol name and a user-defined string for its kind respectively.editor.completion-item-kinds
: A list of the user-defined strings for completion item kinds. When a kind name is not set, it will use the kind's snake_name form instead (the default before this PR)In addition to this, themes are also concerned. The
ui.menu.kind
scope is the default, andui.completion.kind.{name}
for each kind, where {name} is the snake_case name of the kind name.