Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Dispatches have incorrect publishing date #78

Closed
chris-kaiser-7 opened this issue Apr 18, 2024 · 2 comments · Fixed by #79
Closed

[BUG]: Dispatches have incorrect publishing date #78

chris-kaiser-7 opened this issue Apr 18, 2024 · 2 comments · Fixed by #79
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers mapping This issue or it's solution is related to how information is mapped PR ready This issue is approved and ready to be worked on.
Milestone

Comments

@chris-kaiser-7
Copy link

chris-kaiser-7 commented Apr 18, 2024

Link to faulty endpoint

https://helldivers-2-dotnet.fly.dev/api/v1/dispatches

The name of your client/application

curl / browser

Request information

curl 'https://helldivers-2-dotnet.fly.dev/api/v1/dispatches' \
  -H 'authority: helldivers-2-dotnet.fly.dev' \
  -H 'accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7' \
  -H 'accept-language: en-US,en;q=0.9' \
  -H 'cache-control: max-age=0' \
  -H 'sec-ch-ua: "Chromium";v="122", "Not(A:Brand";v="24", "Google Chrome";v="122"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "Linux"' \
  -H 'sec-fetch-dest: document' \
  -H 'sec-fetch-mode: navigate' \
  -H 'sec-fetch-site: none' \
  -H 'sec-fetch-user: ?1' \
  -H 'upgrade-insecure-requests: 1' \
  -H 'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36'

Steps to reproduce

Make a get request to "https://helldivers-2-dotnet.fly.dev/api/v1/dispatches"

What is expected?

published fields in dispatches endpoint reflect the date the dispatch occurred.

What is actually happening?

When making a GET request to "https://helldivers-2-dotnet.fly.dev/api/v1/dispatches" the published fields timestamp seem to be around 18 days behind the actually value. For example the dispatch that was posted today on 4/18/2024 has the value {"published": "2024-03-31T22:49:13Z"} when it should have a value close to "2024-04-18T05:20:03Z".

System Info

No response

Any additional comments?

No response

@chris-kaiser-7 chris-kaiser-7 added the bug Something isn't working label Apr 18, 2024
@dealloc
Copy link
Member

dealloc commented Apr 18, 2024

fairly certain this will be related to #21
appreciate the writeup, this will definitely help finding a fix for this!

@lambstream you up to tackle this one?

@dealloc dealloc added duplicate This issue or pull request already exists good first issue Good for newcomers PR ready This issue is approved and ready to be worked on. mapping This issue or it's solution is related to how information is mapped labels Apr 18, 2024
@dealloc dealloc added this to the V1 milestone Apr 18, 2024
dealloc added a commit that referenced this issue Apr 19, 2024
@dealloc dealloc self-assigned this Apr 19, 2024
@dealloc dealloc linked a pull request Apr 22, 2024 that will close this issue
lambstream pushed a commit that referenced this issue Apr 22, 2024
* account for gametime drift

see #78
see #21

* fix CI warnings
@dealloc
Copy link
Member

dealloc commented Apr 22, 2024

this should be closed with #79

@dealloc dealloc closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers mapping This issue or it's solution is related to how information is mapped PR ready This issue is approved and ready to be worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants