account for gametime drift #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dealloc
added
bug
chatterchats
approved these changes
Apr 19, 2024
lambstream
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #78
see #21
problem ended up being that the dates reported by the planet events and newsfeed are relative to the in-game time (
WarInfo.StartDateandWarStatus.Time), however there's approximately 18 days deviation to 'real world' time (at the time of writing).This patch introduces a
MappingContextwhich, aside from cleaning up mapping code, also hasRelativeGameStartandGameTimeDeviationproperties for dealing with dates that are relative in-game.