Add headers to health check in fly.toml #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included headers `X-Super-Client` and `X-Super-Contact` in the health check configuration. This ensures the health check requests are properly identified and can be managed accordingly.
lambstream
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included headers
X-Super-ClientandX-Super-Contactin the health check configuration. This ensures the health check requests are properly identified and can be managed accordingly.Fly runs a health check on the HTTP endpoint when deploying, however after #114 every request without the
X-Super-*headers failed causing health checks to fail (and thus also the deployment).this is already deployed manually to maintain uptime, but to avoid future deploys breaking again there's this PR