Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix .NET 9 breakages #122

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix .NET 9 breakages #122

merged 1 commit into from
Nov 15, 2024

Conversation

dealloc
Copy link
Member

@dealloc dealloc commented Nov 14, 2024

  • fixes docs no longer building
  • fixes SuperHeadersProcessor being included in Release builds
  • removed obsolete code

@dealloc dealloc added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 14, 2024
@dealloc dealloc added this to the V1 milestone Nov 14, 2024
@dealloc dealloc requested review from lambstream, chatterchats and a team November 14, 2024 22:00
@dealloc @chatterchats
fix .NET 9 breakages
54a6aef 
- fixes docs no longer building
- fixes SuperHeadersProcessor being included in Release builds
- removed obsolete code
chatterchats
chatterchats approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@chatterchats chatterchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look like things shouldn't break

@chatterchats chatterchats merged commit ce4ea75 into master Nov 15, 2024
3 checks passed
@chatterchats chatterchats deleted the feature/dotnet-9 branch November 15, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatterchats chatterchats chatterchats approved these changes

@lambstream lambstream lambstream approved these changes

Assignees

@chatterchats chatterchats

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
V1
Development

Successfully merging this pull request may close these issues.
3 participants
@dealloc @lambstream @chatterchats