Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to latest helldivers-2/json module #69

Merged
merged 2 commits into from
Apr 12, 2024
Merged

update to latest helldivers-2/json module #69

merged 2 commits into from
Apr 12, 2024

Conversation

dealloc
Copy link
Member

@dealloc dealloc commented Apr 12, 2024

  • update source generator to work with new JSON format
  • add environmental and biome data to planets
  • made planet names translatable

@dealloc
update to latest helldivers-2/json module
1554e99 
update source generator to work with new JSON format
add environmental and biome data to planets
made planet names translatable
@dealloc dealloc added feature request This issue requests a feature that doesn't exist (yet) PR ready This issue is approved and ready to be worked on. mapping This issue or it's solution is related to how information is mapped labels Apr 12, 2024
@dealloc dealloc added this to the V1 milestone Apr 12, 2024
@dealloc dealloc requested a review from a team April 12, 2024 00:10
@dealloc dealloc self-assigned this Apr 12, 2024
@dealloc dealloc linked an issue Apr 12, 2024 that may be closed by this pull request
[FEATURE]: provide biome and environment data for planets #64
Closed
@dealloc dealloc linked an issue Apr 12, 2024 that may be closed by this pull request
[FEATURE]: supported different names of planets #50
Closed
@dealloc dealloc mentioned this pull request Apr 12, 2024
Closed
chatterchats
chatterchats approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@chatterchats chatterchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chatterchats chatterchats merged commit 5c9720d into master Apr 12, 2024
1 check passed
@chatterchats chatterchats deleted the feature/planet-data branch April 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatterchats chatterchats chatterchats approved these changes

Assignees

@dealloc dealloc

Labels
feature request This issue requests a feature that doesn't exist (yet) mapping This issue or it's solution is related to how information is mapped PR ready This issue is approved and ready to be worked on.
Projects
None yet
Milestone
V1
Development

Successfully merging this pull request may close these issues.

[FEATURE]: provide biome and environment data for planets [FEATURE]: supported different names of planets
2 participants
@dealloc @chatterchats