modules: Remove error module #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove error module: - Update SEND_FATAL_ERROR() to throw assertion if called. - Subscribe to FATAL ERROR channel in LED module. - Show RED on fatal error. - Update LED toggle and simple config API to use blue instead of red. Red should be reserved for fatal errors. - Minor cleanup in prj.conf. Signed-off-by: Simen S. Røstad <[email protected]>
|
gregersrygg
reviewed
May 29, 2024
| # CONFIG_LOG_MODE_DEFERRED allows logging from multiple threads simultaneously without creating | ||
| # splintered log entries, at the cost of needing a buffer for storing logs. | ||
| CONFIG_LOG=y | ||
| CONFIG_NCS_SAMPLES_DEFAULTS=y |
There was a problem hiding this comment.
Using this kconfig hides that we have asserts and logging enabled. Do we want to hide that instead of explicitly configure each of them?
There was a problem hiding this comment.
Agree. Its best to explicitly state the configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove error module: