Not all 'application/...' mime types are ELF executables

helloSystem · Aug 28, 2023 · 6f81c37 · 6f81c37
1 parent c8a5df4
commit 6f81c37
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/src/Executable.cpp b/src/Executable.cpp
@@ -28,15 +28,12 @@ bool Executable::hasShebang(const QString& path) {
 
 bool Executable::isElf(const QString& path) {
     QMimeDatabase mimeDatabase;
-    QMimeType mimeType = mimeDatabase.mimeTypeForFile(path);
-
-    QStringList allMimeTypeNames = {mimeType.name()};
-    allMimeTypeNames.append(mimeType.allAncestors());
-    qDebug() << "All MIME types for file:" << allMimeTypeNames;
-
-    if (allMimeTypeNames.contains("application/x-executable") || \
-            allMimeTypeNames.contains("application/x-pie-executable") || \
-            allMimeTypeNames.contains("application/vnd-appimage")) {
+    QString mimeType = mimeDatabase.mimeTypeForFile(path).name();
+    // NOTE: Not all "application/..." mime types are ELF executables, e.g., disk images
+    // have "application/..." mime types, too.
+    if (mimeType == "application/x-executable" || \
+        mimeType == "application/x-pie-executable" || \
+        mimeType == "application/vnd-appimage") {
         qDebug() << "File is an ELF executable.";
         return true;
     } else {