[FEAT] SignIn ExposureLogging (#156)

hellokitty-coding-club · Nov 13, 2023 · 27a39a0 · 27a39a0
1 parent 8c202ce
commit 27a39a0
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 8 deletions.
diff --git a/...gtm/domain/logging/CommonLoggingScheme.kt → .../domain/logging/SwmCommonLoggingScheme.kt b/...gtm/domain/logging/CommonLoggingScheme.kt → .../domain/logging/SwmCommonLoggingScheme.kt
@@ -1,14 +1,14 @@
 package com.lgtm.domain.logging
 
-import com.swm.logging.android.logging_scheme.ClickScheme
+import com.swm.logging.android.logging_scheme.SWMLoggingScheme
 import java.lang.reflect.Type
 
-class CommonLoggingScheme(
+class SwmCommonLoggingScheme(
     eventLogName: String,
     screenName: String,
     logVersion: String,
     logData: Map<String, Any>,
-) : ClickScheme() {
+) : SWMLoggingScheme() {
 
     init {
         setLoggingScheme(
@@ -52,11 +52,11 @@ class CommonLoggingScheme(
             return this
         }
 
-        fun build(): CommonLoggingScheme {
+        fun build(): SwmCommonLoggingScheme {
             check(::eventLogName.isInitialized) { "eventLogName is not initialized" }
             check(::screenName.isInitialized) { "screenName is not initialized" }
 
-            return CommonLoggingScheme(
+            return SwmCommonLoggingScheme(
                 eventLogName,
                 screenName,
                 logVersion,

diff --git a/feature/auth/src/main/java/com/lgtm/android/auth/ui/SignInActivity.kt b/feature/auth/src/main/java/com/lgtm/android/auth/ui/SignInActivity.kt
@@ -14,6 +14,7 @@ import com.lgtm.android.auth.ui.signup.SignUpActivity
 import com.lgtm.android.common_ui.base.BaseActivity
 import com.lgtm.android.common_ui.util.NetworkState
 import com.lgtm.android.common_ui.util.setOnThrottleClickListener
+import com.lgtm.domain.logging.SwmCommonLoggingScheme
 import dagger.hilt.android.AndroidEntryPoint
 
 @AndroidEntryPoint
@@ -31,6 +32,7 @@ class SignInActivity : BaseActivity<ActivitySignInBinding>(R.layout.activity_sig
         initClickListener()
         observeGithubLoginResponse()
         observePatchDeviceTokenStatus()
+        shotSignInExposureLogging()
     }
 
     private fun setAnimationOnGithubButton() {
@@ -118,6 +120,15 @@ class SignInActivity : BaseActivity<ActivitySignInBinding>(R.layout.activity_sig
         Toast.makeText(this, message, Toast.LENGTH_SHORT).show()
     }
 
+    private fun shotSignInExposureLogging() {
+        val scheme = SwmCommonLoggingScheme.Builder()
+            .setEventLogName("signInExposure")
+            .setScreenName(this.javaClass)
+            .build()
+        signInViewModel.shotSignInExposureLogging(scheme)
+    }
+
+
     companion object {
         const val MEMBER_DATA = "memberData"
     }

diff --git a/feature/auth/src/main/java/com/lgtm/android/auth/ui/SignInViewModel.kt b/feature/auth/src/main/java/com/lgtm/android/auth/ui/SignInViewModel.kt
@@ -13,6 +13,8 @@ import com.lgtm.android.common_ui.util.NetworkState
 import com.lgtm.domain.entity.LgtmResponseException
 import com.lgtm.domain.entity.response.GithubLoginResponse
 import com.lgtm.domain.repository.AuthRepository
+import com.swm.logging.android.SWMLogging
+import com.swm.logging.android.logging_scheme.SWMLoggingScheme
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.launch
 import javax.inject.Inject
@@ -86,4 +88,8 @@ class SignInViewModel @Inject constructor(
                 }
         }
     }
+
+    fun shotSignInExposureLogging(scheme: SWMLoggingScheme) {
+        SWMLogging.logEvent(scheme)
+    }
 }
diff --git a/feature/auth/src/main/java/com/lgtm/android/auth/ui/splash/SplashActivity.kt b/feature/auth/src/main/java/com/lgtm/android/auth/ui/splash/SplashActivity.kt
@@ -13,7 +13,7 @@ import com.lgtm.android.auth.databinding.ActivitySplashBinding
 import com.lgtm.android.auth.ui.SignInActivity
 import com.lgtm.android.auth.ui.SystemMaintenanceActivity
 import com.lgtm.android.common_ui.base.BaseActivity
-import com.lgtm.domain.logging.CommonLoggingScheme
+import com.lgtm.domain.logging.SwmCommonLoggingScheme
 import dagger.hilt.android.AndroidEntryPoint
 
 @AndroidEntryPoint
@@ -33,7 +33,7 @@ class SplashActivity : BaseActivity<ActivitySplashBinding>(R.layout.activity_spl
     }
 
     private fun shotSplashExposureLogging() {
-        val scheme = CommonLoggingScheme.Builder()
+        val scheme = SwmCommonLoggingScheme.Builder()
             .setEventLogName("splashExposure")
             .setScreenName(this.javaClass)
             .build()

diff --git a/swm-logging/src/main/java/com/swm/logging/android/SWMLogging.kt b/swm-logging/src/main/java/com/swm/logging/android/SWMLogging.kt
@@ -72,7 +72,7 @@ object SWMLogging {
         observable.onNext(swmLoggingScheme)
     }
 
-    suspend fun shotLogging(swmLoggingScheme: SWMLoggingScheme): Response<BaseDTO> {
+    private suspend fun shotLogging(swmLoggingScheme: SWMLoggingScheme): Response<BaseDTO> {
         checkInitialized()
         return loggingService.postLogging(serverPath, swmLoggingScheme)
     }