Update default compile_commands.json path #5
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing the /XXX/ to match the actual definition as stated is a good idea. However this is a breaking change for some that install defaults. The current one works for bazel setups. Maybe this needs to be identified. If there is an indication of Bazel, then use root, otherwise build subdirectory. Bazel can be identified by the presence of file of the following list: |
Signed-off-by: Greg Thornton <[email protected]>
Signed-off-by: Greg Thornton <[email protected]>
xdissent
force-pushed
the
default-compile_commands
branch
from
554aeb5
to
2af4937
Compare
helly25
added a commit
that referenced
this pull request
Jul 7, 2024
… is not found, then the extension will also try `${workspaceFolder}/build/compile_commands.json`.
This should address #5 in slightly better way as it supports both common places.
helly25
added a commit
that referenced
this pull request
Jul 8, 2024
… is not found, then the extension will also try `${workspaceFolder}/build/compile_commands.json`.
This should address #5 in slightly better way as it supports both common places.
helly25
added a commit
that referenced
this pull request
Jul 8, 2024
If `iwyu.compile_commands` is set to the default `auto`, then the extension will try:
- `${workspaceFolder}/compile_commands.json`,
- `${workspaceFolder}/build/compile_commands.json`,
- `${fileWorkspaceFolder}/compile_commands.json`, and
- `${fileWorkspaceFolder}/build/compile_commands.json`.
This should address #5 in slightly better way as it supports the common places.
This fixes #11
|
This PR should no longer be necessary as of version 0.0.16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default
compile_commands.jsonpath reflects the default from the popularCMake Toolsextension and is probably appropriate for >90% of all configurations.