Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release drafter action handles multi-branch releases #1660

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Release drafter action handles multi-branch releases #1660

merged 3 commits into from
Oct 9, 2024

Conversation

JuanPedroGHM
Copy link
Member

@JuanPedroGHM JuanPedroGHM commented Sep 30, 2024 •
edited
Loading

Release drafter action should now be able to distinguish between releases on different branches.

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Add extra option to release-drafter.yml to base the release draft based on the current branch.

Issue/s resolved: #

Changes proposed:

  • "filter-by-commitish: true" -> I don't think I have ever seen it called commitish

@JuanPedroGHM JuanPedroGHM changed the title fix: release drafter configuration Release drafter action handles multi-branch releases Sep 30, 2024
@JuanPedroGHM JuanPedroGHM added workflows CI continuous integration github_actions Pull requests that update GitHub Actions code labels Sep 30, 2024
@JuanPedroGHM JuanPedroGHM requested a review from mtar October 7, 2024 07:42
mtar
mtar approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@mtar mtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JuanPedroGHM JuanPedroGHM merged commit 8b4d990 into main Oct 9, 2024
5 checks passed
@mtar mtar deleted the fix/release-draft-update branch October 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtar mtar mtar approved these changes

Assignees
No one assigned
Labels
CI continuous integration github_actions Pull requests that update GitHub Actions code workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuanPedroGHM @mtar