Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/589 batch normalization #748

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

krajsek
Copy link
Member

@krajsek krajsek commented Mar 18, 2021

Description

Issue/s resolved: #

Changes proposed:

Type of change

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ghost
Copy link

ghost commented May 12, 2022

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Attention: Patch coverage is 18.08511% with 77 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (c282cb1) to head (02a7f82).

Files with missing lines Patch % Lines
heat/nn/batchnorm.py 18.82% 69 Missing ⚠️
heat/nn/__init__.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   92.24%   91.72%   -0.53%     
==========================================
  Files          84       85       +1     
  Lines       12460    12550      +90     
==========================================
+ Hits        11494    11511      +17     
- Misses        966     1039      +73     
Flag Coverage Δ
unit 91.72% <18.08%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@mrfh92 mrfh92 mentioned this pull request Aug 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thank you for the PR!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Thank you for the PR!

@ClaudiaComito ClaudiaComito removed this from the Repo Clean-Up milestone Feb 12, 2025
@github-actions github-actions bot added features testing Implementation of tests, or test-related issues nn labels Feb 13, 2025
@ClaudiaComito ClaudiaComito added the enhancement New feature or request label Feb 13, 2025
Copy link
Contributor

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request features nn testing Implementation of tests, or test-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants