Add array helper concat #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concat uses Array.prototype.concat to concatinate two arrays and return the result. In spirit of the design of other helpers, I made it so that if only the first argument is an array, that array will be returned. If both arguments are an array their concatination is returned. If neither arguments are an array then an empty array is returned.
oleg-codaio
reviewed
Oct 2, 2018
| */ | ||
|
|
||
| helpers.concat = function(arrayA, arrayB) { | ||
| if (Array.isArray(arrayA) && !Array.isArray(arrayB)) { |
There was a problem hiding this comment.
Can I suggest an implementation that would handle more than one array? Something like:
const args = Array.from(arguments);
args.pop(); // Pop off options.
return [].concat(...args)
There was a problem hiding this comment.
That seems doable and a good idea. I'm not sure if functionality like that is desired by the maintainers though, so I will not implement it just yet 🙂
Just for reference, if the current implementation stays you could always do (concat array1 (concat array2 array3)). But of course this may become hard to read for a larger number of arrays.
|
Thanks for the PR. I'll try to review this by the weekend. |
|
(bump) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #330, implemented a helper for arrays named
concatwhich takes two arrays and concatenates them together. Suggestions are welcome 🙂It seems something weird happened when I generated the docs, all forward slashes have been changed to backward slashes 😕 Maybe because I generated them on Windows?