Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mobile interceptor #178

Merged
merged 9 commits into from
Apr 13, 2023
Merged

add mobile interceptor #178

merged 9 commits into from
Apr 13, 2023

Conversation

DasProffi
Copy link
Member

closes #162

@DasProffi DasProffi self-assigned this Apr 11, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 493223e
Status: ✅  Deploy successful!
Preview URL: https://4ac6c0c3.web-d91.pages.dev
Branch Preview URL: https://issue-162-mobile-interceptor.web-d91.pages.dev

View logs

@DasProffi
Copy link
Member Author

Google Play Badge ignored see #182

@DasProffi DasProffi marked this pull request as ready for review April 12, 2023 21:02
@DasProffi DasProffi requested a review from a team as a code owner April 12, 2023 21:02
@DasProffi DasProffi requested review from felixevers and florian-sabonchi and removed request for a team April 12, 2023 21:02
@DasProffi DasProffi requested a review from felixevers April 13, 2023 08:53
@DasProffi
Copy link
Member Author

Should we move the Mobile Interceptor page to the pages, because it isn't exactly navigatable?

@felixevers
Copy link
Member

Should we move the Mobile Interceptor page to the pages, because it isn't exactly navigatable?

Just let it stay in /components. If it is'nt navigable it's no page.

@DasProffi
Copy link
Member Author

@use-to so you approve the PR or are there other requested changes?

@DasProffi DasProffi requested a review from felixevers April 13, 2023 10:13
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commited small suggestions! Feel free to merge it though!

@DasProffi DasProffi merged commit 1bb1c52 into main Apr 13, 2023
@DasProffi DasProffi deleted the issue/162-mobile-interceptor branch April 13, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interceptor for blocking mobile based user agents
2 participants