Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Upgrade init #489

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Feat: Upgrade init #489

merged 10 commits into from
Oct 4, 2023

Conversation

NiclasNorin
Copy link
Contributor

@NiclasNorin NiclasNorin commented Sep 25, 2023 •
edited
Loading

Added functions:

v_1: Handling divider fields as test for first upgrade

Normal modules:

  • migrateAcfFieldsValueToNewFields
  • migrateModuleFields

Blocks:

  • migrateBlockFieldsValueToNewFields
  • migrateBlockFields
  • getPagesFromBlockName

Feat: Upgrade init
555c797 
Added functions migrateAcfFieldValueToNewField, migrateBlockFieldValueToNewField
@NiclasNorin NiclasNorin marked this pull request as draft September 25, 2023 15:10
@NiclasNorin
Copy link
Contributor Author

Task linked: CU-865d4cj28 Modulen "divider" har dubbla titelfält

@NiclasNorin
Copy link
Contributor Author

Task linked: CU-865d5ddfz Upgrade.php i Modularity

@NiclasNorin NiclasNorin changed the base branch from 3.0/develop to main October 3, 2023 06:21
@NiclasNorin NiclasNorin marked this pull request as ready for review October 4, 2023 11:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 39 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sebastianthulin
sebastianthulin approved these changes Oct 4, 2023
View reviewed changes
source/php/Upgrade.php
'post_type' => $moduleName,
);

$modules = get_posts($args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a default limit. Det limit -1

@sebastianthulin sebastianthulin merged commit 29e407d into main Oct 4, 2023
3 of 4 checks passed
@sebastianthulin sebastianthulin deleted the 3.0/feature/upgrade branch October 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianthulin sebastianthulin sebastianthulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiclasNorin @sebastianthulin