Chore/refactoring image module #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Niclas Norin <[email protected]>
* Feat: Manual input module init * Feat: Working card input * Feat: Acf added * Feat: Added views and corrected acf * Feat: Views completed * Fix: Block view not working without out div * Fix: Removing class from block * Fix: Change requests * Fix: Change name to ratio, setting image height and converting ob to arr * Clarify at some points, and remove duplicate function call of no use. * Add icon --------- Co-authored-by: Niclas Norin <[email protected]> Co-authored-by: Sebastian Thulin <[email protected]>
* Refactor: Refactoring image module * Refactor: Removed unused acf field * Refactor: Removed unnecessary view * Refactor: Cleaning up controller * Refactor: Creating a partial and using new vars * Feat: Handle image custom size in a new way --------- Co-authored-by: Niclas Norin <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.