Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce Term helper class to replace static Term helper #1231

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

thorbrink
Copy link
Contributor

@thorbrink thorbrink commented Jan 9, 2025

This pull request includes significant changes to the Term helper class and introduces new interfaces and a new implementation of the Term class. The most important changes include deprecating the old Term class methods, creating new interfaces for term color and icon retrieval, and adding a new Term class implementation. Additionally, tests for the new Term class have been added.

Deprecation and Refactoring:

  • library/Helper/Term.php: Deprecated the old Term class methods and redirected them to use the new Term class implementation.

New Interfaces:

New Implementation:

  • library/Helper/Term/Term.php: Added a new Term class implementing GetTermColor and GetTermIcon interfaces, with methods for retrieving term color and icon, including handling ancestor terms.

Testing:

@thorbrink thorbrink marked this pull request as ready for review January 9, 2025 10:03
Copy link

sonarqubecloud bot commented Jan 9, 2025

@thorbrink thorbrink changed the title feat: introduce TermHelper class with GetTermColor and GetTermIcon in… refactor: introduce Term helper class to replace static Term helper Jan 9, 2025
@thorbrink thorbrink merged commit 48571f8 into main Jan 9, 2025
8 of 9 checks passed
@thorbrink thorbrink deleted the refactor/termHelper branch January 9, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants