Twodimarraydoc #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to add more documentation here. Please do not yet merge. |
|
TODO
|
|
A first set of tests: https://github.com/raoulb/fricas_code/tree/master/matrix_tests |
Now we have the full grid of possibilities implemented: An instance 'M' of a domain satisfying 'TwoDimensionalArrayCategory' is, in the simplest case, indexed by two selectors like: M(u, v) where both u and v can be any of: - A single Integer - An Integer Segment - List of Integers - A List of Integer Segemnts All these functions can not only slice out subsets of M but also create new, larger versions by repeating some parts as specified by repeated selector entries.
Now we have the full grid of possibilities implemented: For 'M', 'N' two instances of a domain satisfying 'TwoDimensionalArrayCategory' we can write the following assignment to a subset of 'M' M(u, v) := N where both selectors u and v can be any of: - A single Integer - An Integer Segment - List of Integers - A List of Integer Segemnts
Before this change, the second and fourth example failed
while the first and third did not. I think ignoring but
not failing on empty segments is the correct fix.
m([1..2,2..1], 1)
+1+
(90) | |
+4+
Type: Matrix(Integer)
m([1..3,3..1], 1)
+1+
| |
(91) |4|
| |
+7+
Type: Matrix(Integer)
m(1, [1..2,2..1])
(92) [1 2]
Type: Matrix(Integer)
m(1, [1..3,3..1])
(93) [1 2 3]
Type: Matrix(Integer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the slicing notation for matrices.