-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graphic showcasing evolution of life #270
Conversation
I am not sure i understand the scaling on your timeline? you normalize earth age to 1 year? IMO it would be clearer if you put 20M years ago etc... I promise I will not be asking for a log scale 🤓 |
marked at midnight. This visualization shows the pivotal steps | ||
of life and sourdough on earth.}% | ||
\end{center} | ||
\end{figure} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is clearer than showing millions of years… I see why you are trying to say but I need to think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the idea from Ed Young's book "I contain multitudes". I kind of like it as it shows how recent all human innovation has been. Also shows how lonely the planet has been for some time. My plan is to add another one with 12000 BC till now once this PR is merged 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to also have non scaled dates maybe in a different colour?
I would also add some key dates like Pangea (you already have dinosaurs extinction). Just an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pangea is a funny idea 👍 . Just not sure I can fit more into that one chart 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - TLDR - it was that recent the continents formed 😅
@cedounet thanks for the Feedback! I fixed most of the issues 👍 . As a basis to calculate I used: "(4.54 billion years / 12 months = 0.3785 billion years/month". I also added it as a comment in the code 😎 |
You might want to reword your dates as well to match American style https://editorsmanual.com/articles/dates-american-vs-british/ this is pretty much what I have in the Chicago manual of style… not ordinals. if we ever want to translate then we should use datetime2 package. I would use it anyway as I would get the date format wrong without looking on the inter webs. |
4e58351
to
4e25af9
Compare
4e25af9
to
e26d85f
Compare
Sweet! Thanks for the tip. I updated - hope I didn't miss something. |
Thanks! I fixed the issues. Also added pangea and squeezed it in. Awesome idea. Can you check one more time please? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe run make check on it. I could only spot one citation mistake.
text ok time chart could be slanted for better readability maybe?
I would add the scaling bottom left of the graph… 1 quarter represents 1 billion year about.
book/history/sourdough-history.tex
Outdated
sourdough breads has been excavated in Switzerland. | ||
However, based on recent research, some scientists speculate that sourdough | ||
bread had already been made in \num{12000}~BC in ancient Jordan~\cite{jordan+bread}. | ||
sourdough breads has been excavated in Switzerland.~\cite{switzerland+bread} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citation before the dot
Great idea 👍. Also thanks for the hint on make check.
…On Mon 6. Nov 2023 at 10:20, cedounet ***@***.***> wrote:
***@***.**** commented on this pull request.
Maybe run make check on it
I would add the scaling bottom left of the graph… 1 quarter represents 1
billion year about.
------------------------------
In book/history/sourdough-history.tex
<#270 (comment)>
:
> bread are, however, unknown. One of the most ancient preserved
-sourdough breads has been excavated in Switzerland.
-However, based on recent research, some scientists speculate that sourdough
-bread had already been made in \num{12000}~BC in ancient Jordan~\cite{jordan+bread}.
+sourdough breads has been excavated in Switzerland.~\cite{switzerland+bread}
Citation before the dot
—
Reply to this email directly, view it on GitHub
<#270 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGHNW26Y2GMWE6QKGBWU6DYC77KHAVCNFSM6AAAAAA6YLRFPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJUGA2TONRUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I really like it now.
|
Great idea 🙏🏻
…On Mon 6. Nov 2023 at 22:59, cedounet ***@***.***> wrote:
I really like it now. Have you tried to use colours?
—
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGHNW6Q6YNPJSKQRVX2KQDYDCYG3AVCNFSM6AAAAAA6YLRFPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGQ3DGNZXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@cedounet what do you think? I also didn't want to overdo the colors. |
Yeah it's a matter of balance... LGTM, we can always fine-tune later anyway. |
* Add graphic showcasing evolution of life * Add PR Feedback * Add comment * Update date format * Fix small mistakes * Add pangea, rewrite intro * Fix citation, improve intro. Thanks alanblue * Add indicator for full span and months * Color improvements
After reading a really good book by Ed Young on microorganism I figured I update the history of sourdough bread a bit more.