Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace starter image with book image #407

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

hendricius
Copy link
Owner

@hendricius hendricius commented Dec 31, 2024

This takes the new starter activity image from the book and adds it to the starter activity chapter. This further introduces some changes to the layout of the website to make reading a bit easier. See ticket #394

image

This takes the new starter activity image from the book and adds it to
the starter activity chapter. This further introduces some changes to
the layout of the website to make reading a bit easier.
@cedounet
Copy link
Collaborator

cedounet commented Jan 1, 2025

Can we have the picture without the text? I would rather we add the box and text with TikZ so that we have consistent colours and fonts with the rest of the book.. on top of being searchable.

that being said, the picture is really clear so that is a great addition.

@hendricius
Copy link
Owner Author

@cedounet generally I think that would be great. But it would also be a lot more work. If you check some of the images from the hardcover version: https://drive.google.com/drive/folders/1nlWeGUB2_fsmozkuhCPZMg-aV8x6yylf?usp=sharing. A lot of them have text on it. So we'd need to apply tikz magic to a lot of pictures :-D

I'd probably long-term change the colors in the current book to match the hardcover? I think they look a bit nicer, but that's just my opinion. Your thoughts?

@cedounet
Copy link
Collaborator

cedounet commented Jan 1, 2025

I thought the colours in color.tex were matching the hardcover obnes. If not they should I agree.

I don’t think adding annotations with TikZ will be too much work, but yeah I should probably do one before talking 🙂

But yes still more work so I am happy we merge pictures from hardcover then replace as we feel the need.

@hendricius
Copy link
Owner Author

@cedounet - attaching the transparent image of the starter:

starter-transparent

You are right - we are already using the correct colors. I was mentally christmas AFK.

I'll merge this for now and we can tackle it in a followup PR.

@hendricius hendricius merged commit 2429ceb into main Jan 2, 2025
2 checks passed
@cedounet cedounet deleted the 394-replace-starter-image-with-image-from-book branch January 3, 2025 16:33
@cedounet
Copy link
Collaborator

cedounet commented Jan 3, 2025

@hendricius

FYI after 5 minutes looks like this. I might increase font size maybe..

image

@hendricius
Copy link
Owner Author

@cedounet Looking great!

@cedounet
Copy link
Collaborator

cedounet commented Jan 6, 2025

Still needs more work, will ge to that later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants