Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the vector embedding for Pgvector #219

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

ollyw
Copy link
Contributor

@ollyw ollyw commented Oct 17, 2024

Description

Fixed the order of filter and ordering parameters

Fixes #218

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This has been tested with pg16 with pgvector in a docker container (image pgvector/pgvector:pg16) by running the openai embedding example. The unit tests were run, but none seem relevant.
It feels that for the longer term, there could be an integration test for this

Checklist:

  • I have read the Contributing documentation.
  • I have read the Code of conduct documentation.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

ollyw and others added 2 commits October 17, 2024 16:39
@henomis henomis self-requested a review November 2, 2024 17:30
@henomis henomis merged commit bf96840 into henomis:main Nov 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using Postgres Index
2 participants