Skip to content

Commit

Permalink
Removing git_command setting.
Browse files Browse the repository at this point in the history
This is more appropriately solved by the user's shell (separation of concerns), also removes the dependency on the config module on the git module.
  • Loading branch information
henvic committed Jan 8, 2015
1 parent 0990ba0 commit cb9a532
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 0 additions & 2 deletions .gh.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

"default_pr_reviewer": "",

"git_command": "git",

"github_token": "",

"github_user": "",
Expand Down
5 changes: 2 additions & 3 deletions lib/git.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@

var base = require('./base'),
logger = require('./logger'),
spawn = require('child_process').spawn,
config = base.getConfig();
spawn = require('child_process').spawn;

exports.checkout = function(branch, opt_newBranch, opt_callback) {
var args;
Expand Down Expand Up @@ -71,7 +70,7 @@ exports.exec = function(cmd, args, opt_callback, opt_log) {

args.unshift(cmd);

git = spawn(config.git_command, exports.deleteArrayEmptyValues_(args));
git = spawn('git', exports.deleteArrayEmptyValues_(args));

git.stdout.on('data', function(data) {
buf += data;
Expand Down

0 comments on commit cb9a532

Please sign in to comment.