Dart: do not generate default clause for enumerations
#1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
----- Motivation ----- In the case of enumerations we match all the possible matchable values in `case` clauses. Then, we generate `default` clause, but the linter is able to see, that this is a dead code. In such case `unreachable_switch_default` warning is raised by the linter. ----- Important ----- The above is true if we generate an authentic `enum` in Dart. In the case when aliasing enumerators are needed, then we generate an enum-like class. In such case `default` clause is needed, because we operate on integers and compiler assumes, that switch-case is not exhaustive. ----- Implemented solution ----- Removed generation of redundant `default` clause when we use an authentic Dart `enum` to avoid linter warnings. Signed-off-by: Patryk Wrobel <[email protected]>
This change adjusts the expected output of smoke tests. The redundant 'default' section is removed for authentic Dart enumerations. Signed-off-by: Patryk Wrobel <[email protected]>
Signed-off-by: Patryk Wrobel <[email protected]>
|
Dart SDK issue and code, which introduced the check for Diagnostic message description: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
----- Motivation -----
In the case of enumerations we match all the possible
matchable values in
caseclauses. Then, we generatedefaultclause, but the linter is able to see, thatthis is a dead code.
In such case
unreachable_switch_defaultwarning israised by the linter.
----- Important -----
The above is true if we generate an authentic
enumin Dart.In the case when aliasing enumerators are needed, then
we generate an enum-like class. In such case
defaultclauseis needed, because we operate on integers and compiler assumes,
that switch-case is not exhaustive.
----- Implemented solution -----
Removed generation of redundant
defaultclause when we usean authentic Dart
enumto avoid linter warnings.