Check result of cache related operations #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustam-gamidov-here
force-pushed
the
rga/olpedge-2852-check-cache-results
branch
from
ded1560 to
9231298
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
+ Coverage 81.05% 81.07% +0.03%
==========================================
Files 341 341
Lines 13255 13278 +23
Branches 1417 1428 +11
==========================================
+ Hits 10743 10765 +22
+ Misses 1938 1933 -5
- Partials 574 580 +6 ☔ View full report in Codecov by Sentry. |
rustam-gamidov-here
force-pushed
the
rga/olpedge-2852-check-cache-results
branch
3 times, most recently
from
9463569 to
d21bc7d
Compare
andrey-kashcheev
previously approved these changes
Jan 25, 2024
rustam-gamidov-here
force-pushed
the
rga/olpedge-2852-check-cache-results
branch
from
d21bc7d to
5f1425a
Compare
|
Please update the description |
olp-cpp-sdk-dataservice-read/src/repositories/PartitionsCacheRepository.cpp
Outdated
Show resolved
Hide resolved
rustam-gamidov-here
force-pushed
the
rga/olpedge-2852-check-cache-results
branch
from
5f1425a to
5c6af10
Compare
rustam-gamidov-here
requested review from
andrey-kashcheev and
mykhailo-kuchma
Skipped as not related to the offline map data: StreamLayerClient, ApiCacheRepository, CatalogSettings Relates-To: OLPEDGE-2852 Signed-off-by: Rustam Gamidov <[email protected]>
rustam-gamidov-here
force-pushed
the
rga/olpedge-2852-check-cache-results
branch
from
5c6af10 to
de6c1c4
Compare
andrey-kashcheev
approved these changes
Jan 30, 2024
mykolamalik
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipped as not related to the offline map data:
StreamLayerClient, ApiCacheRepository, CatalogSettings
Relates-To: OLPEDGE-2852