Return Postponed if protected cache failed to open #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
+ Coverage 81.02% 81.39% +0.38%
==========================================
Files 341 341
Lines 13279 13284 +5
Branches 1429 1431 +2
==========================================
+ Hits 10758 10812 +54
+ Misses 1938 1896 -42
+ Partials 583 576 -7 ☔ View full report in Codecov by Sentry. |
This allows read-only protected cache location at start. Later when there is a need to write to the protected cache it can be opened as mutable and it is going to be an error if we have no write permission at that time. Relates-To: OLPEDGE-2858 Signed-off-by: Rustam Gamidov <[email protected]>
rustam-gamidov-here
force-pushed
the
rga/olpedge-2858-read-only-protected
branch
from
58bb61f to
67fe4c4
Compare
rustam-gamidov-here
requested review from
mykolamalik,
mykhailo-kuchma and
andrey-kashcheev
andrey-kashcheev
approved these changes
Feb 8, 2024
mykhailo-kuchma
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows read-only protected cache location at start. Later when there is a need to write to the protected cache it can be opened as mutable and it is going to be an error if we have no write permission at that time.
Relates-To: OLPEDGE-2858