Allow the user to override C++ standard #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially when this CMakeLists.txt is included from other top-level projects, we shouldn't override the C++ standard if it's already set. Relates-To: MINOR Signed-off-by: Harald Fernengel <[email protected]>
mykhailo-kuchma
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1582 +/- ##
==========================================
- Coverage 81.41% 81.41% -0.01%
==========================================
Files 345 345
Lines 13542 13543 +1
Branches 1463 1463
==========================================
Hits 11025 11025
- Misses 1923 1924 +1
Partials 594 594 ☔ View full report in Codecov by Sentry. |
andrey-kashcheev
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially when this CMakeLists.txt is included from other top-level projects, we shouldn't override the C++ standard if it's already set.
Relates-To: MINOR