-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TECHDOCS-334-language-support #127
Open
ngross71
wants to merge
66
commits into
heremaps:master
Choose a base branch
from
ngross71:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
e03484a
TECHDOCS-534: update multi-language support
ngross71 3b5d389
TECHDOCS-534: update multi-language support
ngross71 4bab9fc
TECHDOCS-1157 add instructions on how to run examples
ngross71 2c2b9b6
TECHDOCS-1157 add instructions on how to run examples
ngross71 c729e87
Merge pull request #1 from ngross71/TECHDOCS-1157-add-instructions-ex…
ngross71 6c4355d
Create main.yml
ngross71 c1c2561
add pipeline
ngross71 f064c8d
add pipeline
ngross71 0c36b5d
add pipeline
ngross71 4440dbf
add pipeline
ngross71 f54e483
add pipeline
ngross71 a5f75e7
add pipeline
ngross71 54e25ed
add pipeline
ngross71 fd43d22
add pipeline
ngross71 8465654
add pipeline
ngross71 0a844c4
add pipeline
ngross71 625302f
add pipeline
ngross71 6f6c3fd
add pipeline
ngross71 18c09e3
add pipeline
ngross71 6791968
add pipeline
ngross71 9743156
add pipeline
ngross71 1824f23
add pipeline
ngross71 ec70916
add pipeline
ngross71 3377f18
add pipeline
ngross71 817cf9b
add pipeline
ngross71 ee05db7
add pipeline
ngross71 5da0153
add pipeline
ngross71 cb8f323
add pipeline
ngross71 9d97528
add pipeline
ngross71 c7a0411
add pipeline
ngross71 ff63756
add pipeline
ngross71 89fcda3
add pipeline
ngross71 4c88f3d
add pipeline
ngross71 7313cb2
add pipeline
ngross71 f496d4c
add pipeline
ngross71 72a534e
add pipeline
ngross71 aff7826
install jsdom
ngross71 320b44e
install jsdom
ngross71 2b9df5b
install jsdom
ngross71 ac6e2c0
install jsdom
ngross71 a19bad6
install jsdom
ngross71 ae0b377
install jsdom
ngross71 4594739
install jsdom
ngross71 e587b51
install jsdom
ngross71 d9607ba
install jsdom
ngross71 38bfd3d
install jsdom
ngross71 1733c9f
install jsdom
ngross71 3883d50
install jsdom
ngross71 9e0c568
install jsdom
ngross71 c338b7d
install jsdom
ngross71 c99989c
install jsdom
ngross71 8931944
install jsdom
ngross71 7103b9c
install jsdom
ngross71 3e57533
install jsdom
ngross71 ee74f3e
install jsdom
ngross71 912e864
install jsdom
ngross71 3d94524
install jsdom
ngross71 cba36e6
install jsdom
ngross71 6579f82
install jsdom
ngross71 3acbb6c
install jsdom
ngross71 7f9b464
install jsdom
ngross71 cbb160a
install jsdom
ngross71 69727d9
install jsdom
ngross71 5d824dd
install jsdom
ngross71 68f55a6
install jsdom
ngross71 f88a076
install jsdom
ngross71 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -19,7 +19,7 @@ | |||||
<h1>Interactive base map</h1> | ||||||
<p>Retrieve information associated with the map features</p> | ||||||
</div> | ||||||
<p>This example demonstrates how to enable the interactions with the base map features. The interactions are enabled for the countries' | ||||||
<p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples">the README</a> for instructions on how to run the example.The interactions are enabled for the countries' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
What's the reason for adding this line only to this example? |
||||||
cities', towns' and neighbourhoods' labels. When these labels are clicked the info bubble with the information about the label is shown. | ||||||
</p> | ||||||
<div id="map"></div> | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid giving direct instructions on where to clone the repo.
Therefore I would rephrase this like so: