Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECHDOCS-334-language-support #127

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
e03484a
TECHDOCS-534: update multi-language support
ngross71 Oct 12, 2021
3b5d389
TECHDOCS-534: update multi-language support
ngross71 Oct 13, 2021
4bab9fc
TECHDOCS-1157 add instructions on how to run examples
ngross71 May 11, 2022
2c2b9b6
TECHDOCS-1157 add instructions on how to run examples
ngross71 May 13, 2022
c729e87
Merge pull request #1 from ngross71/TECHDOCS-1157-add-instructions-ex…
ngross71 May 17, 2022
6c4355d
Create main.yml
ngross71 Jul 7, 2022
c1c2561
add pipeline
ngross71 Jul 7, 2022
f064c8d
add pipeline
ngross71 Jul 7, 2022
0c36b5d
add pipeline
ngross71 Jul 7, 2022
4440dbf
add pipeline
ngross71 Jul 7, 2022
f54e483
add pipeline
ngross71 Jul 7, 2022
a5f75e7
add pipeline
ngross71 Jul 7, 2022
54e25ed
add pipeline
ngross71 Jul 7, 2022
fd43d22
add pipeline
ngross71 Jul 7, 2022
8465654
add pipeline
ngross71 Jul 7, 2022
0a844c4
add pipeline
ngross71 Jul 7, 2022
625302f
add pipeline
ngross71 Jul 8, 2022
6f6c3fd
add pipeline
ngross71 Jul 8, 2022
18c09e3
add pipeline
ngross71 Jul 12, 2022
6791968
add pipeline
ngross71 Jul 13, 2022
9743156
add pipeline
ngross71 Jul 13, 2022
1824f23
add pipeline
ngross71 Jul 13, 2022
ec70916
add pipeline
ngross71 Jul 13, 2022
3377f18
add pipeline
ngross71 Jul 14, 2022
817cf9b
add pipeline
ngross71 Jul 14, 2022
ee05db7
add pipeline
ngross71 Jul 19, 2022
5da0153
add pipeline
ngross71 Jul 19, 2022
cb8f323
add pipeline
ngross71 Jul 19, 2022
9d97528
add pipeline
ngross71 Jul 19, 2022
c7a0411
add pipeline
ngross71 Jul 19, 2022
ff63756
add pipeline
ngross71 Jul 19, 2022
89fcda3
add pipeline
ngross71 Jul 19, 2022
4c88f3d
add pipeline
ngross71 Jul 19, 2022
7313cb2
add pipeline
ngross71 Jul 19, 2022
f496d4c
add pipeline
ngross71 Jul 19, 2022
72a534e
add pipeline
ngross71 Jul 19, 2022
aff7826
install jsdom
ngross71 Jul 25, 2022
320b44e
install jsdom
ngross71 Jul 25, 2022
2b9df5b
install jsdom
ngross71 Jul 25, 2022
ac6e2c0
install jsdom
ngross71 Jul 25, 2022
a19bad6
install jsdom
ngross71 Jul 25, 2022
ae0b377
install jsdom
ngross71 Jul 25, 2022
4594739
install jsdom
ngross71 Jul 25, 2022
e587b51
install jsdom
ngross71 Jul 25, 2022
d9607ba
install jsdom
ngross71 Jul 25, 2022
38bfd3d
install jsdom
ngross71 Jul 25, 2022
1733c9f
install jsdom
ngross71 Jul 25, 2022
3883d50
install jsdom
ngross71 Jul 25, 2022
9e0c568
install jsdom
ngross71 Jul 25, 2022
c338b7d
install jsdom
ngross71 Jul 25, 2022
c99989c
install jsdom
ngross71 Jul 25, 2022
8931944
install jsdom
ngross71 Jul 25, 2022
7103b9c
install jsdom
ngross71 Jul 25, 2022
3e57533
install jsdom
ngross71 Jul 25, 2022
ee74f3e
install jsdom
ngross71 Jul 25, 2022
912e864
install jsdom
ngross71 Jul 25, 2022
3d94524
install jsdom
ngross71 Jul 26, 2022
cba36e6
install jsdom
ngross71 Jul 26, 2022
6579f82
install jsdom
ngross71 Jul 26, 2022
3acbb6c
install jsdom
ngross71 Jul 26, 2022
7f9b464
install jsdom
ngross71 Jul 26, 2022
cbb160a
install jsdom
ngross71 Jul 26, 2022
69727d9
install jsdom
ngross71 Aug 1, 2022
5d824dd
install jsdom
ngross71 Aug 1, 2022
68f55a6
install jsdom
ngross71 Aug 1, 2022
f88a076
install jsdom
ngross71 Aug 1, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Maps API for JavaScript

This repository holds a series of JavaScript based examples using the **HERE Maps API for JavaScript**. More information about the API can be found on [developer.here.com](https://developer.here.com/develop/javascript-api) under the JavaScript APIs section.
This repository holds a series of JavaScript based examples using the **HERE Maps API for JavaScript**. More information about the API can be found on [developer.here.com](https://developer.here.com/develop/javascript-api) under the JavaScript APIs section.
To run the examples, clone this repo to a folder on your Desktop. Replace the credentials in the **test-credentials.js** file with your own credentials.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid giving direct instructions on where to clone the repo.
Therefore I would rephrase this like so:

Suggested change
To run the examples, clone this repo to a folder on your Desktop. Replace the credentials in the **test-credentials.js** file with your own credentials.
To run the examples, clone this repo and replace the credentials in the **test-credentials.js** file with your own credentials.


> **Note:** In order to get the sample code to work, you **must** replace all instances of `window.apikey` within the code and use your own **HERE** credentials.

Expand All @@ -22,7 +23,6 @@ All of the following examples use **version 3.1** of the API
* [Display KML Data](https://heremaps.github.io/maps-api-for-javascript-examples/display-kml-on-map/demo.html) - Parse a KML file and display the data on a map
* [Display GeoJSON Data](https://heremaps.github.io/maps-api-for-javascript-examples/display-geojson-on-map/demo.html) - Parse a GeoJSON file and display the data on a map
* [Display an Indoor Map](https://heremaps.github.io/maps-api-for-javascript-examples/indoor-map/demo.html) - Use the HERE Indoor Maps API to load and visualize an indoor map
* [Display routing on an Indoor Map](https://heremaps.github.io/maps-api-for-javascript-examples/indoor-map-routing/demo.html) - Use the HERE Indoor Maps API to calculate an indoor-outdoor route
* [Draggable Marker](https://heremaps.github.io/maps-api-for-javascript-examples/draggable-marker/demo.html) - Display a moveable marker on a map
* [Draggable geo shapes](https://heremaps.github.io/maps-api-for-javascript-examples/draggable-shapes/demo.html) - Display moveable geometric shapes on a map
* [Extruded geo shapes](https://heremaps.github.io/maps-api-for-javascript-examples/extruded-objects/demo.html) - 3D extrusion of the geometric shapes
Expand Down
2 changes: 1 addition & 1 deletion interactive-basemap/demo.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<h1>Interactive base map</h1>
<p>Retrieve information associated with the map features</p>
</div>
<p>This example demonstrates how to enable the interactions with the base map features. The interactions are enabled for the countries'
<p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples">the README</a> for instructions on how to run the example.The interactions are enabled for the countries'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples">the README</a> for instructions on how to run the example.The interactions are enabled for the countries'
<p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples#maps-api-for-javascript">the README</a> for instructions on how to run the example. The interactions are enabled for the countries'

What's the reason for adding this line only to this example?

cities', towns' and neighbourhoods' labels. When these labels are clicked the info bubble with the information about the label is shown.
</p>
<div id="map"></div>
Expand Down
4 changes: 3 additions & 1 deletion map-multi-language-support/demo.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ <h3>Code</h3>
<p>A reference to the base map tile service is obtained using the <code>H.service.Platform</code>.
Alternate languages can be requested by adding the <code>lg</code> parameter to the tile requests.
That is done by calling createTileLayer method. 5th argument is list of key/value parameters which are
passed to the map tile service when requesting each tile. List of all supported map languages can be found in the API References of the underlying service you are using.</p>
passed to the map tile service when requesting each tile.
A list of all supported map languages can be found in the API References of the underlying service used: <a href="https://developer.here.com/documentation/map-tile/dev_guide/topics/resource-base-maptile.html">HERE Map Tile API</a>
and <a href="https://developer.here.com/documentation/vector-tiles-api/dev_guide/topics/languages.html">HERE Vector Tile API</a> </p>
<p>It is possible to specify map language for all layers at once when using <code>H.service.Platform.createDefaultLayers</code> method.</p>
<p>Language of the UI controls can be specified when calling <code>H.ui.UI.createDefault</code> method.
3rd argument is either a supported language code or a custom <code>H.ui.i18n.Localization object</code>.</p>
Expand Down