Merge pull request #1066 from mkroening/min-mem-locking

perf(fs/mem): minimize locking duration of pos
hermit-os · Feb 14, 2024 · 3d3299f · 3d3299f
2 parents 938bf3a + c59d822
commit 3d3299f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/fs/mem.rs b/src/fs/mem.rs
@@ -52,8 +52,7 @@ impl ObjectInterface for RomFileInterface {
 	async fn poll(&self, event: PollEvent) -> Result<PollEvent, IoError> {
 		let mut result: PollEvent = PollEvent::empty();
 		let len = self.inner.read().await.data.len();
-		let pos_guard = self.pos.lock().await;
-		let pos = *pos_guard;
+		let pos = *self.pos.lock().await;
 
 		if event.contains(PollEvent::POLLIN) && pos < len {
 			result.insert(PollEvent::POLLIN);
@@ -138,8 +137,7 @@ impl ObjectInterface for RamFileInterface {
 	async fn poll(&self, event: PollEvent) -> Result<PollEvent, IoError> {
 		let mut result: PollEvent = PollEvent::empty();
 		let len = self.inner.read().await.data.len();
-		let pos_guard = self.pos.lock().await;
-		let pos = *pos_guard;
+		let pos = *self.pos.lock().await;
 
 		if event.contains(PollEvent::POLLIN) && pos < len {
 			result.insert(PollEvent::POLLIN);