-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic support a linux-like syscall evendfd
#1052
Conversation
To avoid debug messages of unhandled interrupts, a handler for COM1 is registerted.
fine-tuning of the TCP stack and the behavior of the system call `poll`
increasing the event counter blocks, if a overflow is possible
Can we add some kind of test for this functionality? |
There will be one on the user space side of things. Revamping integration tests in this repo is another thing that I should move up on my list. Then, we could test those things easily here as well: #418 |
if smoltcp leaves the state LISTEN, the poll function returns Poll::Ready. Just to give the user space the option to call accept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I have two comments that I will address after merging.
I also opened #1060 since we don't need async
locks in numerous instances.
I merge this PR. Just to release a new abi and to publish some ci test. |
eventfd
creates an linux-like "eventfd object" that can be used as an event wait/notify mechanism by user-space applications, and by the kernel to notify user-space applications of events. The object contains an unsigned 64-bit integer counter that is maintained by the kernel. This counter is initialized with the value specified in the argumentinitval
.As its return value,
eventfd
returns a new file descriptor that can be used to refer to the eventfd object.The following values may be bitwise set in flags to change the behavior of
eventfd
:EFD_NONBLOCK
: Set the file descriptor in non-blocking modeEFD_SEMAPHORE
: Provide semaphore-like semantics for reads from the new file descriptor.In addition, the PR includes some fine-tuning of the IP stack and the behavior of the system call
poll
. This should increase the compatibility to Unix.