Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuse: reduce copying and handle errors #1084

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fuse: reduce copying and handle errors #1084

merged 1 commit into from
Mar 13, 2024

Conversation

cagatay-y
Copy link
Contributor

Instead of copying the commands into Virtqueue buffers and the buffers back into responses, directly provide the commands and responses as references to the send_command method.

@stlankes stlankes self-requested a review March 4, 2024 11:20
@stlankes stlankes self-assigned this Mar 4, 2024
@stlankes stlankes assigned mkroening and unassigned stlankes Mar 4, 2024
@mkroening mkroening self-requested a review March 4, 2024 11:52
mkroening
mkroening approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mkroening mkroening added this pull request to the merge queue Mar 13, 2024
Merged via the queue into hermit-os:main with commit d118729 Mar 13, 2024
13 checks passed
@cagatay-y cagatay-y deleted the copyless-send-command branch April 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroening mkroening mkroening approved these changes

@stlankes stlankes stlankes approved these changes

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cagatay-y @stlankes @mkroening