feat: add virtio-def crate for virtio definitions
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
virtio-def
branch
4 times, most recently
from
c1ea040 to
343a3a5
Compare
mkroening
requested review from
stlankes and
cagatay-y
and removed request for
stlankes
stlankes
approved these changes
Apr 27, 2024
cagatay-y
reviewed
Apr 29, 2024
| @@ -141,13 +142,13 @@ impl ComCfg { | |||
|
|
|||
| /// Returns the device status field. | |||
| pub fn dev_status(&self) -> u8 { | |||
| unsafe { read_volatile(&self.com_cfg.status).try_into().unwrap() } | |||
| unsafe { read_volatile(&self.com_cfg.status).bits() } | |||
There was a problem hiding this comment.
Is there a reason to return the underlying u8 instead of a DeviceStatus?
There was a problem hiding this comment.
No, we should do that! But the scope of this PR is just changing the underlying types without separate changes to the API that can happen later. :)
cagatay-y
reviewed
Apr 29, 2024
cagatay-y
reviewed
Apr 29, 2024
cagatay-y
approved these changes
Apr 30, 2024
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
This comment was made obsolete by 68effc9#diff-aec828209d10fe04d7a8a6f063279edaa909f90ecabc93f062445611e4f63972L380 Signed-off-by: Martin Kröning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.