Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtio/pci): remove ComCfgRaw #1255

Merged
merged 1 commit into from
Jun 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions src/drivers/virtio/transport/pci.rs
Original file line number Diff line number Diff line change
Expand Up @@ -570,33 +570,6 @@ impl ComCfg {
}
}

/// Common configuration structure of Virtio PCI devices.
/// See Virtio specification v1.1 - 4.1.43
///
/// Fields read-write-rules in source code refer to driver rights.
#[repr(C)]
struct ComCfgRaw {
// About whole device
device_feature_select: u32, // read-write
device_feature: u32, // read-only for driver
driver_feature_select: u32, // read-write
driver_feature: u32, // read-write
config_msix_vector: u16, // read-write
num_queues: u16, // read-only for driver
device_status: DeviceStatus, // read-write
config_generation: u8, // read-only for driver

// About a specific virtqueue
queue_select: u16, // read-write
queue_size: u16, // read-write
queue_msix_vector: u16, // read-write
queue_enable: u16, // read-write
queue_notify_off: u16, // read-only for driver. Offset of the notification area.
queue_desc: u64, // read-write
queue_driver: u64, // read-write
queue_device: u64, // read-write
}

/// Notification Structure to handle virtqueue notification settings.
/// See Virtio specification v1.1 - 4.1.4.4
pub struct NotifCfg {
Expand Down