Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow mounting a virtiofsd share to / #774

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Jun 20, 2023

In case, that the fuse device use the tag '/', the kernel scans the root directory of the fuse device and mounts all directories to /.

In addition, the PR revises getdents64 to be compatible to the Linux system call

@stlankes stlankes marked this pull request as draft June 20, 2023 19:10
@stlankes stlankes requested review from mkroening and removed request for mkroening June 20, 2023 19:11
@stlankes stlankes force-pushed the fs branch 3 times, most recently from 4af2f65 to 09c8272 Compare June 23, 2023 20:08
@stlankes stlankes force-pushed the fs branch 2 times, most recently from 1bdf352 to 3760aca Compare April 23, 2024 19:19
@stlankes stlankes changed the title add virtiofs tests mount all fuse directories to / Apr 23, 2024
@stlankes stlankes marked this pull request as ready for review April 23, 2024 19:21
@stlankes stlankes requested a review from mkroening April 23, 2024 19:22
@stlankes
Copy link
Contributor Author

@mkroening Can you review the PR?

With tag `/`, the kernel scans the root directory of the fuse device and mounts all directories to `/`.
@mkroening mkroening changed the title mount all fuse directories to / feat: allow mounting a virtiofsd share to / Apr 24, 2024
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@mkroening mkroening added this pull request to the merge queue Apr 24, 2024
Merged via the queue into hermit-os:main with commit 97c3e33 Apr 24, 2024
13 checks passed
@mkroening mkroening deleted the fs branch April 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants