Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KVM tests with uhyve, qemu and firecracker #895

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Sep 5, 2023

Closes #868

@stlankes stlankes force-pushed the kvm branch 3 times, most recently from 8a46cad to 4b0f2eb Compare September 5, 2023 18:03
@stlankes stlankes marked this pull request as draft September 5, 2023 19:13
@stlankes stlankes force-pushed the kvm branch 2 times, most recently from 03435d7 to dcd90f4 Compare September 6, 2023 09:55
@stlankes stlankes changed the title add KVM tests add KVM tests with uhyve, qemu and firecracker Sep 6, 2023
@stlankes stlankes marked this pull request as ready for review September 6, 2023 09:56
@stlankes stlankes requested a review from mkroening September 6, 2023 09:56
@stlankes
Copy link
Contributor Author

stlankes commented Sep 6, 2023

@mkroening Do you know, how can I determine the version of firecracker. Currently, I use the command "firecracker-v1.4.1-x86_64" to start firecracker, which is bad if the version increased.

- improve the readability
@mkroening
Copy link
Member

mkroening commented Sep 6, 2023

@mkroening Do you know, how can I determine the version of firecracker. Currently, I use the command "firecracker-v1.4.1-x86_64" to start firecracker, which is bad if the version increased.

I think for now this is fine. There are options such as gh release list, but I am not certain how to integrate them best. Maybe an explicit version is good for now?

@stlankes stlankes added this pull request to the merge queue Sep 6, 2023
Merged via the queue into hermit-os:main with commit 00f93f0 Sep 6, 2023
9 checks passed
@stlankes stlankes deleted the kvm branch September 6, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants