use from_{ref,mut} to eliminate casts to pointers

[cagatay-y]

As it stands, the PR requires ptr_from_ref and strict_provenance to land in stable. If the ptr_from_ref lands first, the branch can be updated to make use of the polyfill for the pointer::addr method in the sptr crate, as instructed in its documentation.

[mkroening]

@cagatay-y, ptr_from_ref will be stable with tomorrow's 1.76.0 release.

[mkroening]

ptr_from_ref is now stable. :)

[mkroening]

Let's replace all instances of ptr::from_ref(unsafe {&foo}) with ptr::addr_of!(foo).

[mkroening]

Same for replacing ptr::from_ref(unsafe {&mut foo}) with ptr::addr_of_mut!(foo).

[cagatay-y]

Do you mean the ones inside a from_raw_parts_mut? We have to have an unsafe block for from_raw_parts_mut in that case. Of course, I can convert them too, I am asking to make sure I am not missing something else.

[mkroening]

Do you mean the ones inside a from_raw_parts_mut? We have to have an unsafe block for from_raw_parts_mut in that case. Of course, I can convert them too, I am asking to make sure I am not missing something else.

Yeah. While the amount of unsafe blocks stays the same in those cases, the amount of unsafe operations would be less. And it would be more consistent with the rest of the code.

[mkroening]

Sorry for not catching this earlier, but can we also enable the corresponding lint?
https://rust-lang.github.io/rust-clippy/master/index.html#ref_as_ptr

[cagatay-y]

I can't get the lint to work on my machine. It complains that no such lint exists. I am version on 0.1.77. Does it work for you?

[mkroening]

I can't get the lint to work on my machine. It complains that no such lint exists. I am version on 0.1.77. Does it work for you?

Ah, true. This will be in Rust 1.77.0, but the current stable is 1.76.0.

[mkroening]

Thanks!