Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run KVM jobs on GitHub runners #748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: run KVM jobs on GitHub runners #748

wants to merge 2 commits into from

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Aug 29, 2024

This allows running the Uhyve CI without requiring self-hosted runners.

@mkroening mkroening self-assigned this Aug 29, 2024
@mkroening mkroening force-pushed the github-runner branch 4 times, most recently from bde0995 to 6fd69b8 Compare February 20, 2025 09:18
@mkroening mkroening marked this pull request as draft February 20, 2025 09:18
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (b63a14f) to head (c753d59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   71.67%   71.67%           
=======================================
  Files          25       25           
  Lines        3181     3181           
=======================================
  Hits         2280     2280           
  Misses        901      901           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkroening mkroening force-pushed the github-runner branch 4 times, most recently from 3ec1f48 to c6cd766 Compare February 20, 2025 09:51
@mkroening mkroening marked this pull request as ready for review February 20, 2025 10:18
@mkroening mkroening assigned jounathaen and unassigned mkroening Feb 20, 2025
@mkroening mkroening requested a review from jounathaen February 20, 2025 10:18
@jounathaen
Copy link
Member

So we had an internal discussion, and came to the conclusion that a switch only provides minor benefits at the moment and keeping a little independence with our infrastructure is a value on its own.

But we keep the PR open, so we can easily adapt if the need for the GH runners occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants