feat(uhyve): spawn UhyveVm in a new thread #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of an ongoing effort to support Landlock without enforcing restrictions globally, as Uhyve is not presumed to only spawn one UhyveVm before exiting. It is also my hope that I will be able to benchmark things better.
n0toose
commented
Dec 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 71.56% 71.49% -0.08%
==========================================
Files 22 22
Lines 3028 3031 +3
==========================================
Hits 2167 2167
- Misses 861 864 +3 ☔ View full report in Codecov by Sentry. |
|
Honestly, presently this only introduces overhead without any benefits. I'm looking forward to the landlock implementation, maybe this change will be able to highlight its benefits better then. |
|
As discussed in person, the underlying issue will be solved in another way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of an ongoing effort to support Landlock without enforcing restrictions globally, as Uhyve is not presumed to only spawn one UhyveVm before exiting. It is also my hope that I will be able to benchmark things better.